-
-
Notifications
You must be signed in to change notification settings - Fork 235
Symfony 8 support follow-up, PHPUnit 11 #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2f9393d to
d6646c1
Compare
|
The CI was already red before this PR btw |
d6646c1 to
b00e50c
Compare
b00e50c to
9ef85eb
Compare
|
@dunglas PR rebased, I also fixed |
d488b41 to
6a05d18
Compare
|
Everything is green 🙌🏻 |
6a05d18 to
cc37227
Compare
cc37227 to
db5316b
Compare
db5316b to
b3470ca
Compare
phpstan.neon
Outdated
| - '#Return type \(void\) of method Symfony\\Component\\Panther\\DomCrawler\\Crawler::clear\(\) should be compatible with return type \(Facebook\\WebDriver\\WebDriverElement\) of method Facebook\\WebDriver\\WebDriverElement::clear\(\)#' | ||
| - '#Return type \(ArrayIterator<int, Facebook\\WebDriver\\WebDriverElement>\) of method Symfony\\Component\\Panther\\DomCrawler\\Crawler::getIterator\(\) should be compatible with return type \(ArrayIterator<int, DOMNode>\) of method Symfony\\Component\\DomCrawler\\Crawler::getIterator\(\)#' | ||
| # PHPStan runs with lowest dependencies | ||
| - '#Attribute class PHPUnit\\Framework\\Attributes\\DataProvider does not exist\.#' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we could bump the PHPUnit version in the PHPStan job. We usually run PHPStan only with the latest dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will requires php-webdriver/php-webdriver#1134
This PR was merged into the 2.x branch. Discussion ---------- Tests on Symfony 8 stable | Q | A | -------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md --> | Documentation? | no <!-- required for new features, or documentation updates --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> The following jobs are still impossible to make them green for the following reasons: - Functional Tests / turbo-tests (8.4, stable): waiting for symfony/panther#678 - Functional Tests / turbo-tests (8.5, stable): sam as above - Functional Tests / turbo-tests (dev, 8.5): same as above - Unit Tests / php (8.4, 8.0.*) : waiting for some `zenstruck/*` packages to be compatible with Symfony 8, and `spatie/phpunit-snapshot-assertions` (but couldn't be installed unless we require PHPUnit 10) - Unit Tests / php (8.5, 8.0.*) : same as above Commits ------- 724429c Tests on Symfony 8 stable
IIRC the CI was already broken before this PR